Skip to content

Conversation

@hetangmodi-crest
Copy link
Contributor

@hetangmodi-crest hetangmodi-crest commented Apr 16, 2025

Issue number: ADDON-76780

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

This PR contains generation of template python files (which will import logic from the files provided by the users) for the custom search command.
For now, we are not supporting generation of python files for Transforming/Reporting command.

User experience

After defining required and valid configuration for custom search command in globalconfig.json, required template python files (based on the command type specified by the user) will be generated for the users, which will import logic from the files provided by the users.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest merged commit 3776f0e into feat/add-validations-for-csc May 9, 2025
92 checks passed
@hetangmodi-crest hetangmodi-crest deleted the feat/generation-of-python-files-for-csc branch May 9, 2025 12:35
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants