-
Notifications
You must be signed in to change notification settings - Fork 35
feat: generation of python files for custom search command #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hetangmodi-crest
merged 8 commits into
feat/add-validations-for-csc
from
feat/generation-of-python-files-for-csc
May 9, 2025
Merged
feat: generation of python files for custom search command #1697
hetangmodi-crest
merged 8 commits into
feat/add-validations-for-csc
from
feat/generation-of-python-files-for-csc
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This was referenced Apr 16, 2025
splunk_add_on_ucc_framework/generators/python_files/create_custom_command_python.py
Show resolved
Hide resolved
splunk_add_on_ucc_framework/generators/python_files/create_custom_command_python.py
Outdated
Show resolved
Hide resolved
splunk_add_on_ucc_framework/generators/python_files/create_custom_command_python.py
Outdated
Show resolved
Hide resolved
...ted_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/bin/countmatches.py
Show resolved
Hide resolved
splunk_add_on_ucc_framework/generators/python_files/create_custom_command_python.py
Outdated
Show resolved
Hide resolved
splunk_add_on_ucc_framework/generators/python_files/create_custom_command_python.py
Show resolved
Hide resolved
sgoral-splunk
approved these changes
May 9, 2025
…ython-files-for-csc
3776f0e
into
feat/add-validations-for-csc
92 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-76780
PR Type
What kind of change does this PR introduce?
Summary
Changes
This PR contains generation of template
python files(which will import logic from the files provided by the users) for the custom search command.For now, we are not supporting generation of python files for
Transforming/Reportingcommand.User experience
After defining required and valid configuration for custom search command in globalconfig.json, required template python files (based on the command type specified by the user) will be generated for the users, which will import logic from the files provided by the users.
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear